Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/#275] animated topAppBar #293

Merged
merged 5 commits into from
Aug 12, 2024
Merged

[Feature/#275] animated topAppBar #293

merged 5 commits into from
Aug 12, 2024

Conversation

chattymin
Copy link
Contributor

@chattymin chattymin commented Aug 11, 2024 •
edited
Loading

Issue

Overview (Required)

  • Added AnimatedTextTopAppBar and apply about feature
  • Apply figma

Links

Movie (Optional)

Before After
before.mp4
new_animation.mp4

chattymin
chattymin commented Aug 11, 2024
View reviewed changes
...onMain/kotlin/io/github/droidkaigi/confsched/designsystem/component/AnimatedTextTopAppBar.kt Outdated

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun AnimatedTextTopAppBar(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is similar to issue #228. However, this feature requires the use of TopAppBar, while issue #288 requires LargeTopAppBar, making it difficult to use a common component for both. Therefore, I implemented it separately and submitted a PR.

@github-actions GitHub Actions
Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 11, 2024 11:08 Inactive
@github-actions GitHub Actions
Copy link

Snapshot diff report

File name Image
AboutScreenTest[Abou
tScreen - when launc
h - it should show d
etail section]_compa
re.png

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 11, 2024 11:41 Inactive
@takahirom takahirom mentioned this pull request Aug 11, 2024
Merged
@takahirom
Copy link
Member

Thank you for your contribution. The animation is awesome. However, our designer prefers the #292 animation. Could you use AnimatedLargeTopAppBar instead?
#292 (comment)

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 12, 2024 03:54 Inactive
@chattymin
Copy link
Contributor Author

Thank you for your contribution. The animation is awesome. However, our designer prefers the #292 animation. Could you use AnimatedLargeTopAppBar instead? #292 (comment)

Sure! However, #292 uses a LargeTopAppBar with an icon at the top, while #293 uses a TopAppBar without an icon. If we use the AnimatedLargeTopAppBar as is, it will include a back icon at the top. Even if we set the icon to be optional and hide it, there will still be unnecessary padding.

So, instead of using AnimatedLargeTopAppBar, I used a custom component that I created and added the same fade-in and fade-out animations as in #292. What do you think about this approach? @takahirom

@takahirom
Copy link
Member

Sounds good! That would be appreciated!

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 12, 2024 05:26 Inactive
@takahirom takahirom merged commit a7282cd into DroidKaigi:main Aug 12, 2024
6 checks passed
@takahirom
Copy link
Member

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Centering the app bar on the About list screen when scrolling
2 participants
@chattymin @takahirom